gergely/gergelypolonkai-web-jekyll
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix escaping in latest post

Browse Source 
…thanks, `markdown-mode`.
This commit is contained in:
Gergely Polonkai 2017-03-26 23:05:16 +02:00
parent 4084aa2389
commit fd2243bda6
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
_posts/2017-03-26-category-based-logging-with-flask.md
View File

@ -40,14 +40,14 @@ Now if you add a new variable to the formatter like my new `%(category)s`,
you get a nifty `KeyError` saying there is no `category` in the format you get a nifty `KeyError` saying there is no `category` in the format
expansion dictionary. If you add `category='auth` to the expansion dictionary. If you add `category='auth` to the
`app.logger.info()` calls and its cousins, it’s fine, because these methods `app.logger.info()` calls and its cousins, it’s fine, because these methods
use the magic `\*\*kwarg` argument to swallow it. Everything goes well until use the magic `**kwarg` argument to swallow it. Everything goes well until
control arrives to the `\_log()` method: it complains about that extra control arrives to the `_log()` method: it complains about that extra
`category` keyword argument. Taking a peek at Python’s internals, I found `category` keyword argument. Taking a peek at Python’s internals, I found
two things: `info()`, `error()`, and co. pass `\*args` and `\*\*kwargs` to two things: `info()`, `error()`, and co. pass `*args` and `**kwargs` to
`\_log()` unmodified, and the `\_log()` method doesn’t have `\*\*kwargs` `_log()` unmodified, and the `_log()` method doesn’t have `**kwargs`
present in its definition to swallow it. A little doc reading later I found present in its definition to swallow it. A little doc reading later I found
that if I want to pass extra arguments for such a formatter, I should do it that if I want to pass extra arguments for such a formatter, I should do it
via the `extra` keyword argument to `\_log()`. A call like via the `extra` keyword argument to `_log()`. A call like
`app.logger.info('invalid password', extra={'category': 'auth'})` solved the `app.logger.info('invalid password', extra={'category': 'auth'})` solved the
problem. Now *that* is tedious. problem. Now *that* is tedious.
@ -56,8 +56,8 @@ and `error()`, and handle `category` there. But this resulted in lots of
repeating code. I changed the specification a bit, so my calls would look repeating code. I changed the specification a bit, so my calls would look
like `info('message', category='auth)` instead of the original plan of like `info('message', category='auth)` instead of the original plan of
`info('auth', 'message')`: as the logging methods pass all keyword arguments `info('auth', 'message')`: as the logging methods pass all keyword arguments
to `\_log()`, I can handle it there. So at the end, my new logger class to `_log()`, I can handle it there. So at the end, my new logger class
only patches `\_log()`, by picking out `category` from the kwarg list, and only patches `_log()`, by picking out `category` from the kwarg list, and
inserting it to `extra` before calling `super`. inserting it to `extra` before calling `super`.
As you can see, this is a bit ugly solution. It requires me, the app As you can see, this is a bit ugly solution. It requires me, the app