gergely/astrognome
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Now correctly freeing xml variable in ag_app_open_chart()

Browse Source
This commit is contained in:
Gergely Polonkai 2013-09-17 21:51:43 +02:00
parent ed14c5b092
commit 142f3b2374
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ag-app.c
View File

@ -219,6 +219,7 @@ ag_app_open_chart(AgApp *app, GFile *file)
if ((doc = xmlReadMemory(xml, length, "chart.xml", NULL, 0)) == NULL) { if ((doc = xmlReadMemory(xml, length, "chart.xml", NULL, 0)) == NULL) {
// TODO: Warn with a popup or similar way // TODO: Warn with a popup or similar way
g_warning("Saved chart is corrupt (or not a saved chart at all)"); g_warning("Saved chart is corrupt (or not a saved chart at all)");
g_free(xml);
g_free(uri); g_free(uri);
return; return;
@ -228,6 +229,7 @@ ag_app_open_chart(AgApp *app, GFile *file)
// TODO: Warn with a popup or similar way // TODO: Warn with a popup or similar way
g_warning("Could not initialize XPath"); g_warning("Could not initialize XPath");
xmlFreeDoc(doc); xmlFreeDoc(doc);
g_free(xml);
g_free(uri); g_free(uri);
return; return;
@ -259,6 +261,7 @@ ag_app_open_chart(AgApp *app, GFile *file)
g_variant_unref(minute); g_variant_unref(minute);
g_variant_unref(second); g_variant_unref(second);
g_free(xml);
g_free(uri); g_free(uri);
xmlXPathFreeContext(xpathCtx); xmlXPathFreeContext(xpathCtx);
xmlFreeDoc(doc); xmlFreeDoc(doc);